Simplify agent #48
Merged
Simplify agent #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quite
force-pushed
the
simplify-agent
branch
2 times, most recently
from
145f18b
to
d92f3d5
Compare
quite
force-pushed
the
simplify-agent
branch
5 times, most recently
from
f16b62f
to
b1cd9ac
Compare
We connect before and disconnect after every TKey operation. Loading the signer-app as needed. Leaving the TKey's serial port accessible to others. The actual closing of the serial port happens 3聽seconds after the last call to disconnect(). A call to connect() will also cancel any pending disconnection. This helps greatly with ssh login performance. The udev rule that sends SIGHUP to tkey-ssh-agent upon insert/remove of TKey is of course no longer needed. Also send more notifications to help user out of some dead-ends. Co-authored-by: Daniel Lublin <daniel@lublin.se> Signed-off-by: Daniel Lublin <daniel@lublin.se>
Avoiding bugs when conn, a serial.Port interface, is of a type that satisfies the interface, but has the value nil (in which case conn==nil will be false). Signed-off-by: Daniel Lublin <daniel@lublin.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.