Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video resolution #46

Closed
jmmena opened this issue Dec 2, 2020 · 7 comments
Closed

Video resolution #46

jmmena opened this issue Dec 2, 2020 · 7 comments
Labels
wontfix This will not be worked on

Comments

@jmmena
Copy link

jmmena commented Dec 2, 2020

Tilman, great work!
This isn´t a issue. I´ve tested the scritp and it works ok.
Only one question: the output video resolution is 800x600. I wonder if it would be possible to configure the script for another type of resolution, for example 1280x720. This is the deskshare.webm original file resolution (in the example i´ve tested).
thanks in advance

@tilmanmoser
Copy link
Owner

Hi. Video resolution is derived from the viewport settings in shapes.svg as set by big blue button itself; i.e. different presentations may have different video resolutions. The presentation video is created by taking screenshots from this file in a headless chromium browser. Setting another viewport could result in odd aspect ratios. But you could resize the whole video with ffmpeg easily afterwards.

@tilmanmoser tilmanmoser added the enhancement New feature or request label Dec 2, 2020
@jmmena
Copy link
Author

jmmena commented Dec 2, 2020

Hi! Ok, that´s clear.
Thanks for your answer (and for the script)

@tilmanmoser
Copy link
Owner

Just to make that point clear: I marked this as an enhancement, since I understand that it would be good to have some control over the resulting video resolution. It's just not trivial and I add it to the mabe-later-list :-)

@osintaras
Copy link

Thank you for your good work!
Please tell me in which file you can change the resolution of the final video, while you have not done it yet?

@tilmanmoser
Copy link
Owner

tilmanmoser commented Mar 15, 2021

Hi @osintaras - I'm currently not intending to build this into the script, since there are two issues with it:

  1. If the desired video resolution is higher than the actual source material, it would result in a grainy video, which is not desired.
  2. Resizing the video during composition results in ffmpeg reencoding the whole video, which results in significant longer run time and resource usage.

I suggest you resize the video after creation with a command like ffmpeg -i video.mp4 -vf scale=320:-2 video2.mp4, which would render the video to a width of 320px while preserving the aspect ratio.

@tilmanmoser tilmanmoser added wontfix This will not be worked on and removed enhancement New feature or request labels Mar 15, 2021
@osintaras
Copy link

Hi @osintaras - I'm currently not intending to build this into the script, since there are two issues with it:

  1. If the desired video resolution is higher than the actual source material, it would result in a grainy video, which is not desired.
  2. Resizing the video during composition results in ffmpeg reencoding the whole video, which results in significant longer run time and resource usage.

I suggest you resize the video after creation with a command like ffmpeg -i video.mp4 -vf scale=320:-2 video2.mp4, which would render the video to a width of 320px while preserving the aspect ratio.

Hi @tilmanmoser.
If i open bbb presentation on my computer in browser with resolution 1920x1080 and will record screen, then result video have better quality and resolution than 800x600. Because text, cursor and other vector elements have full resolution that gives browser. If your wonderful script had the ability to configure the resolution of the virtual browser in which the video will be captured, this would be great!
Resizing video after creation is an artificial way. The video won't get any better.

@parreitu
Copy link

Hi @tilmanmoser

I agree with @osintaras , it'd be great it we could configure the resolution of the virtual browser in order to change the resolution of the result video.

Thanks for your great job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants