Update to fhir 0.11.0 and flutter 3.10.0 #15
Conversation
v0.9.0-dev.1
sp-nazar
force-pushed
the
fhir_0.11.0
branch
2 times, most recently
from
68cab34
to
1a2c258
Compare
|
please @tiloc integrate it as soon as possible |
|
Hi, I am experiencing issues with this PR. When I am using the Cherryblossom Filler from the example gallery, I am consistently getting an exception related to the weight field. It says it cannot locate the ucum-bodyweight value set. Can you please unbreak this? Apart from that I am in awe of all the hard work that has gone into this! |
|
@tiloc, we would like to help this PR to get in. Could you please share how are you running the quality check so that we can cover your exceptions as well? |
|
@tiloc any update? can you provide some feedback on what is the bug and how to reproduce it? |
Hi, @easazade , I encountered the bug when I ran the demo application and chose the "Cherryblossom Filler" example. Towards the end of the form one of the questions displays an error message instead of the question. This was not the case prior to this PR. |
There was a problem hiding this comment.
Hello.
I don't know if this may have to do with the bug reported by @tiloc before, but I believe there are a few unintended bugs introduced in this PR due to the removal of QuestionnaireItemType, QuestionnaireResponseStatus and other enums from the fhir package, and the way these changes were addressed.
I have marked below some of the ones I could find (there appears to be a lot more). Hope this is of help.
You may want to refer to the FHIR docs for the codes in question:
| @@ -152,7 +152,7 @@ class CodingAnswerModel extends AnswerModel<OptionsOrString, OptionsOrString> { | |||
|
|
|||
| bool get isCheckbox => qi.isItemControl('check-box'); | |||
|
|
|||
| bool get isOptionsOrString => qi.type == QuestionnaireItemType.open_choice; | |||
| bool get isOptionsOrString => qi.type.value == 'open_choice'; | |||
There was a problem hiding this comment.
| bool get isOptionsOrString => qi.type.value == 'open_choice'; | |
| bool get isOptionsOrString => qi.type.value == 'open-choice'; |
| item: items, | ||
| ); | ||
| } else if (itemType == QuestionnaireItemType.datetime) { | ||
| } else if (itemType.value == 'datetime') { |
There was a problem hiding this comment.
| } else if (itemType.value == 'datetime') { | |
| } else if (itemType.value == 'dateTime') { |
| case 'eq': | ||
| case 'ne': |
There was a problem hiding this comment.
| case 'eq': | |
| case 'ne': | |
| case '=': | |
| case '!=': |
| case 'lt': | ||
| case 'gt': | ||
| case 'ge': | ||
| case 'le': |
There was a problem hiding this comment.
| case 'lt': | |
| case 'gt': | |
| case 'ge': | |
| case 'le': | |
| case '<': | |
| case '>': | |
| case '>=': | |
| case '<=': |
| .questionnaireResponseModel | ||
| .responseStatus | ||
| .value == | ||
| 'in_progress' |
There was a problem hiding this comment.
| 'in_progress' | |
| 'in-progress' |
Hi, if the latest versions of the fhir package have removed things that would be beneficial to faiadashu, then we should also consider reaching out to @Dokotela Grey Faulkenberry and see if it can be re-added. He's been quite supportive and appreciative of feedback on his packages in the past. |
This merge combines recent updates of fhir and flutter.
I got some errors while try to compile faiadashu with new Flutter 3.10.0. Fhir package was updated recently with these fixes.
Notice
I temporary disable faiadashu_online and fhir_auth from the example, fhir_auth has not yet updated to fhir 0.11.0.