watch: fix a dumb errcheck (#3622)

tilt-dev · Jul 27, 2020 · 143c02c · 143c02c
1 parent 39544b5
commit 143c02c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/internal/watch/notify.go b/internal/watch/notify.go
@@ -80,7 +80,7 @@ func DesiredWindowsBufferSize() int {
 	envVar := os.Getenv(WindowsBufferSizeEnvVar)
 	if envVar != "" {
 		size, err := strconv.Atoi(envVar)
-		if err != nil {
+		if err == nil {
 			return size
 		}
 	}

diff --git a/internal/watch/notify_test.go b/internal/watch/notify_test.go
@@ -23,6 +23,20 @@ import (
 // Each implementation of the notify interface should have the same basic
 // behavior.
 
+func TestWindowsBufferSize(t *testing.T) {
+	orig := os.Getenv(WindowsBufferSizeEnvVar)
+	defer os.Setenv(WindowsBufferSizeEnvVar, orig)
+
+	os.Setenv(WindowsBufferSizeEnvVar, "")
+	assert.Equal(t, defaultBufferSize, DesiredWindowsBufferSize())
+
+	os.Setenv(WindowsBufferSizeEnvVar, "a")
+	assert.Equal(t, defaultBufferSize, DesiredWindowsBufferSize())
+
+	os.Setenv(WindowsBufferSizeEnvVar, "10")
+	assert.Equal(t, 10, DesiredWindowsBufferSize())
+}
+
 func TestNoEvents(t *testing.T) {
 	f := newNotifyFixture(t)
 	defer f.tearDown()