store: even if a local_resource has no build command, it can still be…

… pending (#4161)

internal/store/manifest_target.go

@@ -30,11 +30,18 @@ func (t ManifestTarget) Status() model.TargetStatus {
 
 func (mt *ManifestTarget) UpdateStatus() model.UpdateStatus {
 	m := mt.Manifest
+	us := mt.State.UpdateStatus(m.TriggerMode)
+
+	if us == model.UpdateStatusPending {
+		// A resource with no update command can still be in pending mode.
+		return us
+	}
+
 	if m.IsLocal() && m.LocalTarget().UpdateCmd.Empty() {
 		return model.UpdateStatusNotApplicable
 	}
 
-	return mt.State.UpdateStatus(m.TriggerMode)
+	return us
 }
 
 var _ model.Target = &ManifestTarget{}

internal/store/manifest_target_test.go

@@ -4,7 +4,9 @@ import (
 	"encoding/base64"
 	"fmt"
 	"testing"
+	"time"
 
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/tilt-dev/tilt/pkg/model"
@@ -31,3 +33,16 @@ func TestManifestTarget_FacetsSecretsScrubbed(t *testing.T) {
 
 	require.Equal(t, expected, actual)
 }
+
+func TestLocalTargetUpdateStatus(t *testing.T) {
+	m := model.Manifest{Name: "serve-cmd"}.WithDeployTarget(
+		model.NewLocalTarget("serve-cmd", model.Cmd{}, model.ToHostCmd("busybox httpd"), nil))
+	mt := NewManifestTarget(m)
+	assert.Equal(t, model.UpdateStatusPending, mt.UpdateStatus())
+
+	mt.State.AddCompletedBuild(model.BuildRecord{StartTime: time.Now(), FinishTime: time.Now()})
+	assert.Equal(t, model.UpdateStatusNotApplicable, mt.UpdateStatus())
+
+	mt.State.TriggerReason = model.BuildReasonFlagTriggerWeb
+	assert.Equal(t, model.UpdateStatusPending, mt.UpdateStatus())
+}