tiltfile/yaml: encode empty lists as empty lists instead of null (#3568)

tilt-dev · Jul 9, 2020 · c133ff8 · c133ff8
1 parent 3c55cf6
commit c133ff8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/tiltfile/encoding/starlark.go b/internal/tiltfile/encoding/starlark.go
@@ -61,7 +61,7 @@ func convertStarlarkToStructuredData(v starlark.Value) (interface{}, error) {
 	case starlark.Float:
 		return float64(v), nil
 	case *starlark.List:
-		var ret []interface{}
+		ret := []interface{}{}
 
 		it := v.Iterate()
 		defer it.Done()

diff --git a/internal/tiltfile/encoding/yaml_test.go b/internal/tiltfile/encoding/yaml_test.go
@@ -305,6 +305,7 @@ key5: 3
 key6:
 - foo
 - 7
+key7: []
 '''
 observed = encode_yaml({
   'key1': 'foo',
@@ -316,7 +317,8 @@ observed = encode_yaml({
   'key6': [
     'foo',
     7,
-  ]
+  ],
+  'key7': []
 })
 
 load('assert.tilt', 'assert')