Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Helm images with colons #1059

Closed
jabdoa2 opened this issue Jan 24, 2019 · 1 comment · Fixed by #1090
Closed

Support Helm images with colons #1059

jabdoa2 opened this issue Jan 24, 2019 · 1 comment · Fixed by #1090
Labels
bug Something isn't working

Comments

@jabdoa2
Copy link

jabdoa2 commented Jan 24, 2019

Tags in images (e.g. registry.tld/path/image:1) do not work in tilt. It will complain that image registry.tld/path/image is not used in any resource. Even if I run: docker_build("registry.tld/path/image:1", ".")`. This is a show stopper for us because we would have to change all helm charts to use it.

@jazzdan jazzdan added the bug Something isn't working label Jan 24, 2019
@nicks
Copy link
Member

nicks commented Jan 24, 2019

sorry you ran into this! we're working on making this better.

You can keep the show going right now by just dropping the tag in the docker_build call. Tilt ignores the tag anyway. i.e.,

docker_build("registry.tld/path/image", ".")

@dougsparling also ran into this and has an open PR so that it doesn't fail so cryptically: #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants