Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension fetcher should grab the whole directory, not just the Tiltfile #3482

Closed
maiamcc opened this issue Jun 19, 2020 · 1 comment · Fixed by #3779
Closed

Extension fetcher should grab the whole directory, not just the Tiltfile #3482

maiamcc opened this issue Jun 19, 2020 · 1 comment · Fixed by #3779
Labels
enhancement New feature or request

Comments

@maiamcc
Copy link
Contributor

maiamcc commented Jun 19, 2020

As seen in tilt-dev/tilt-extensions#35, sometimes an extension relies on more files than just the Tiltfile (e.g. supplementary scripts). It would be useful if the Tilt extension fetcher grabbed the whole directory of an extension, not just the Tiltfile. (Though: would there be security risks here?)
@maiamcc maiamcc added the enhancement New feature or request label Jun 19, 2020
@maiamcc maiamcc mentioned this issue Jun 19, 2020
Merged
@nicks nicks mentioned this issue Sep 4, 2020
Merged
nicks added a commit that referenced this issue Sep 15, 2020
@nicks
tiltextension: download the whole directory instead of just the tiltf…
e31bc00 
…ile. Fixes #3482
@nicks nicks mentioned this issue Sep 15, 2020
Merged
nicks added a commit that referenced this issue Sep 15, 2020
@nicks
tiltextension: download the whole directory instead of just the tiltf…
0b0aac8 
…ile. Fixes #3482
nicks added a commit that referenced this issue Sep 16, 2020
@nicks
tiltextension: download the whole directory instead of just the tiltf…
646c878 
…ile. Fixes #3482 (#3779)
@nicks
Copy link
Member

nicks commented Sep 16, 2020

fixed in v0.17.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@nicks @maiamcc