Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/ Warning filters show that there are entries, but the log view is empty. #4258

Closed
SupremeTechnopriest opened this issue Mar 1, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@SupremeTechnopriest
Copy link

Expected Behavior

When the filters say there are errors or warnings selecting on the filter should display them.

Current Behavior

The log area only shows headers of all the resources. I think these are a little misleading and you can probably do without the headers. Especially when there are no errors or warnings to report for that resource.

image

Steps to Reproduce

  1. Deploy some resources that will throw warnings or errors.
  2. Switch to the new UI .
  3. Click the filter for warning/ error.
  4. Observe the log area.

Context

tilt doctor Output

$ tilt doctor

Tilt: v0.18.9, built 2021-02-12
System: darwin-amd64
---
Docker
- Host: [default]
- Version: 1.41
- Builder: 2
---
Kubernetes
- Env: docker-for-desktop
- Context: docker-desktop
- Cluster Name: docker-desktop
- Namespace: default
- Container Runtime: docker
- Version: v1.19.3
- Cluster Local Registry: none
---
Thanks for seeing the Tilt Doctor!
Please send the info above when filing bug reports. 💗

The info below helps us understand how you're using Tilt so we can improve,
but is not required to ask for help.
---
Analytics Settings
--> (These results reflect your personal opt in/out status and may be overridden by an `analytics_settings` call in your Tiltfile)
- User Mode: opt-out
- Machine: b07ff31bcc0852cb4ed113aa80c93207
- Repo: trjiT0Rdv7yICO5gwAvx0g==

About Your Use Case

Discussed with Han over a zoom call.

@SupremeTechnopriest SupremeTechnopriest added the bug Something isn't working label Mar 1, 2021
@nicks
Copy link
Member

nicks commented Mar 1, 2021

ooh thanks for the detailed report! @markgarrigan pointed this out to me this morning...i wonder if this is a recent regression

@nicks
Copy link
Member

nicks commented Mar 8, 2021

fixed by #4285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants