Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: print container restart #4285

Merged
merged 1 commit into from Mar 8, 2021
Merged

engine: print container restart #4285

merged 1 commit into from Mar 8, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 8, 2021

Hello @maiamcc, @hyu,

Please review the following commits I made in branch nicks/ch11536:

1495a42 (2021-03-08 12:47:30 -0500)
engine: print container restart

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from hyu and maiamcc March 8, 2021 17:56
@shortcut-integration
Copy link

@nicks
Copy link
Member Author

nicks commented Mar 8, 2021

I'm not super tied to this exact wording. here's a picture of how this looks in the UI:

Screenshot from 2021-03-05 19-53-00

Copy link
Contributor

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! My only concern is that this messaging might get confusing in cases where we need to do a crash rebuild, but definitely better than the current state!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants