-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack Overflow / Panic with Docker Compose project #4797
Comments
Could this be related? #4795 |
Thanks for the report! Do you have any repro information you're able to share? |
Since you're on the latest version of Docker for Mac, could you try to parse your Run from directory with your docker-compose enable-v2
docker-compose config You might need to pass some placeholder values for your environment values for it to substitute, e.g.
If it successfully outputs a version of your config, great! If it outputs an error, can you paste back here? (After you've done this, you can always switch back to Compose v1 with |
@milas No problem. We had to turn off compose v2 to deal with this issue, which y'all merged (thanks!).
|
I'd be happy to share the |
Shared some additional details with @milas on Slack. Y'all are incredible as always. Thanks again and let me know if there's anything additional I can share. |
Some of the `compose-go` types are not marshalable with `yaml.v3`: they will trigger infinite recursion and a stack overflow panic. Internally, `compose-cli` uses `yaml.v2` when marshaling (e.g. for output via `docker-compose config`). This is now explicitly used, and a test has been added to prevent regression. Due to other issues/requirements, `compose-go` is also in the midst of upgrading to `yaml.v3`, so in the future we should be able to upgrade it and switch to `yaml.v3` for marshaling its types. Fixes #4797.
Thanks for sharing your compose file! I just opened #4799 which now passes using it :) |
Some of the `compose-go` types are not marshalable with `yaml.v3`: they will trigger infinite recursion and a stack overflow panic. Internally, `compose-cli` uses `yaml.v2` when marshaling (e.g. for output via `docker-compose config`). This is now explicitly used, and a test has been added to prevent regression. Due to other issues/requirements, `compose-go` is also in the midst of upgrading to `yaml.v3`, so in the future we should be able to upgrade it and switch to `yaml.v3` for marshaling its types. Fixes #4797.
Expected Behavior
Tilt commands should not result in a stack overflow and panic. This seems likely related to issues with docker-compose YAML parsing and the injection of environment variables, but I'll continue to dig in.
Current Behavior
Context
tilt doctor
OutputThe text was updated successfully, but these errors were encountered: