-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up PVCs created by VolumeClaimTemplates #5717
Comments
Our use case is that we spin up a temporary postgres statefulset which we proxy to during some migration tests for a |
I utilize the behavior of PVCs being retained in my normal flows, if it is unintentional i'd love to see some way to replicate this behavior after a fix implemented. |
FWIW, this behavior is built into StatefulSet. See here: https://kubernetes.io/docs/tasks/run-application/delete-stateful-set/#persistent-volumes though i have wondered what more controls over volume management in tilt might look like. |
we would love this - right now we do this in our
Which is basically a hack. |
I don't know, I feel like by definition, a PersistentVolumeClaim should persist between The Tilt behavior is similar to when you spin down a I'm pretty sure, I can see the use case to blow the PVCs away thought but it doesn't seem like it should be the default. Maybe there should be a |
Any updates on this? |
Describe the Feature You Want
e.g.:
tilt up
causes the pvcdata-mysql-0
to be created.tilt down
should cause it to be deleted.Current Behavior
Tilt is unaware of this PVC and does not touch it on
down
. This is presumably because the helm yaml doesn't actually include the PVC, but rather specifies StatefulSet.Spec.VolumeClaimTemplates, which, IIUC, causes the PVC to be created.As a workaround, a user can put something like this in their Tiltfile:
which is functional, but involves 1) the user getting past what feels like a bug and 2) hardcoding the pvc names (or somehow querying for them)
Why Do You Want This?
While users often want PVCs to persist, the default behavior in Tilt is still to delete PVCs, and it feels buggy that Tilt misses this case.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: