timing: a few simple tilt up cases #116
Conversation
| | _ < __/\__ \ |_| | | |_\__ \_ | ||
| |_| \_\___||___/\__,_|_|\__|___(_)''' | ||
|
|
||
| BLORGLY_BACKEND_DIR = os.path.join(os.environ['GOPATH'], 'src/github.com/windmilleng/blorgly-backend') |
There was a problem hiding this comment.
Should we be using blorg-backend for our benchmarks since @yuindustries discovered that blorgly-backend is kind of borked?
There was a problem hiding this comment.
is it? how so? (i forgot about that.)
There was a problem hiding this comment.
Blorgly-Backend is not actually hooked up to the frontend. The original idea was for it to provide random strings, but it neither generates those strings nor seems to have ever been successfully tested communicating with the frontend when everyone's deployed to K8s. (It was tested on local, though, and I assume it works there.)
There was a problem hiding this comment.
hmm so i feel like as long as it deploys (which it does), it doesn't matter if it works -- but also i don't have strong feelings and am happy to defer to others here
There was a problem hiding this comment.
I think it's fine to use blorg-backend for now, since for milestone purposes I'd want anything related to output to be merged in sooner rather than later. And I agree with your logic.
I myself ended up using blorg-backend for the Docker for Mac test (PITA though it is, with its Cockroach DB setup and such) because I couldn't figure out another way of verifying that "everything works."
scripts/timing.py
Outdated
| from subprocess import call | ||
|
|
||
| RESULTS_BLOCKLTR = ''' ____ _ _ | ||
| | _ \ ___ ___ _ _| | |_ ___ _ |
scripts/timing.py
Outdated
|
|
||
|
|
||
| def main(): | ||
| print 'NOTE: this script doesn\'t install `tilt` for you, and relies on you having the ' \ |
There was a problem hiding this comment.
uhhhh i guess we could be? i guess the blocker was fab, so that'd probs be fine. will make that change first thing tomorrow
| | _ < __/\__ \ |_| | | |_\__ \_ | ||
| |_| \_\___||___/\__,_|_|\__|___(_)''' | ||
|
|
||
| BLORGLY_BACKEND_DIR = os.path.join(os.environ['GOPATH'], 'src/github.com/windmilleng/blorgly-backend') |
There was a problem hiding this comment.
not for this pr, but i wonder if this will eventually become a more OO class where the current backend dir and service names are fields of the class
There was a problem hiding this comment.
totes, that makes sense
maiamcc
force-pushed
the
maiamcc/prelim-timing-script
branch
from
a5309fb
to
d901da2
Compare
| - Our Python scripts are in Python 3.6.0. To run them: | ||
| - **[pyenv](https://github.com/pyenv/pyenv#installation)** | ||
| - **python**: `pyenv install` | ||
| - if you're using GKE and get the error: "pyenv: python2: command not found", run: |
Hello @jazzdan, @nicks,
the beginnings of a timing script that should hopefully be extensible n stuff