hud/server: enable websocket compression #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May help with situations where Tilt is being run on a remote server and the web UI is running on a local laptop resulting in the websocket messages being sent over the Internet like in #3359.
|
Yeah I poked around in perf and didn't notice an appreciable increase in CPU, or a disproportionate amount of time being spend compressing data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May help with situations where Tilt is being run on a remote server and
the web UI is running on a local laptop resulting in the websocket
messages being sent over the Internet like in #3359.
Currently seeing if there is a measurable performance impact here, but I figure if it's a wash, then we might as well enable this. WDYT?