Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: remove facets flag #3401

Merged
merged 1 commit into from Jun 3, 2020
Merged

feature: remove facets flag #3401

merged 1 commit into from Jun 3, 2020

Conversation

jazzdan
Copy link
Contributor

@jazzdan jazzdan commented Jun 3, 2020

No description provided.

@jazzdan jazzdan requested review from nicks and landism June 3, 2020 19:42
@jazzdan jazzdan merged commit 3ff2f48 into master Jun 3, 2020
@wu-victor
Copy link
Contributor

@jazzdan:

  1. Is there any user-facing impact with this change?
  2. What caused this change? Is there a clubhouse story or a #tilt discussion somewhere?

Thanks.

@jazzdan
Copy link
Contributor Author

jazzdan commented Jun 3, 2020

If you were setting the facets feature flag previously now that will be an error and you will have to delete that from your Tiltfile. Otherwise there's no user facing change @victorwuky

@wu-victor
Copy link
Contributor

Thanks @jazzdan

@nicks nicks deleted the dmiller/remove-facets-feature-flag branch February 3, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicks nicks nicks approved these changes

@landism landism Awaiting requested review from landism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jazzdan @wu-victor @nicks