Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: forcing an update should also force a pod update. Fixes https://github.com/tilt-dev/tilt/issues/1928 #3413

Merged
merged 1 commit into from Jun 8, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Jun 5, 2020

Hello @jazzdan, @maiamcc,

Please review the following commits I made in branch nicks/ch4742:

7cf255f (2020-06-05 17:35:16 -0400)
engine: forcing an update should also force a pod update. Fixes #1928

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from jazzdan and maiamcc June 5, 2020 21:37
@nicks
Copy link
Member Author

nicks commented Jun 5, 2020

This is obviously a very simple solution to a pretty complex problem.

Hitting the "force update" button will replace the existing pods, even if they haven't changed. I think this is closer to what most people expect from this button, based on the feedback I've heard and Maia's discussion here: #1928 (comment)

I still think there's value in more full-featured solutions, but this has been outstanding for so long, I'm hoping that this will fix 90% of the problems

@nicks nicks merged commit 0ba1a83 into master Jun 8, 2020
@nicks nicks deleted the nicks/ch4742 branch June 8, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual restart of pod from dashboard
2 participants