New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: fix some unit tests. Tests should generally not assert things in a goroutine #3424

Merged

nicks merged 1 commit into master from nicks/tests

Jun 8, 2020

Member

nicks commented Jun 8, 2020

Hello @nicks,

Please review the following commits I made in branch nicks/tests:

e6cf7e2 (2020-06-08 13:00:13 -0400)
engine: fix some unit tests. Tests should generally not assert things in a goroutine

Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics


          engine: fix some unit tests. Tests should generally not assert things…

e6cf7e2

… in a goroutine

nicks merged commit 8c343bd into master

nicks deleted the nicks/tests branch

June 8, 2020 17:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment