tiltfile: improve the unmatched image warning message. Fixes https://github.com/tilt-dev/tilt/issues/3410 #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzdan
approved these changes
Jun 9, 2020
| // 1) They didn't include any Kubernetes or Docker Compose configs at all. | ||
| // 2) They included Kubernetes configs, but they're custom resources | ||
| // and Tilt can't infer the image. | ||
| // 3) They typo'd the image name, and need help finding the right name. |
There was a problem hiding this comment.
The one that @jgoulah seemed to be encountering is a slight variation on this, because of misconfiguration the YAML that should have consumed this was never included.
I don't think it's possible to account for this at this point in the code, I think this is more of a job for facets. Just wanted to note it here.
There was a problem hiding this comment.
its similar to a typo but it also pops up when helm values don't render the image tag or if tht tag isn't what tilt expects
There was a problem hiding this comment.
ya, i added some info to this to the comment. I have ideas on tooling to help with this, though it's slightly different than the facets approach. stay tuned!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan,
Please review the following commits I made in branch nicks/ch7422:
fc66199 (2020-06-09 12:28:48 -0400)
tiltfile: improve the unmatched image warning message. Fixes #3410
Code review reminders, by giving a LGTM you attest that: