Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: increase process kill timeout #3444

Merged
merged 4 commits into from Jun 11, 2020
Merged

engine: increase process kill timeout #3444

merged 4 commits into from Jun 11, 2020

Conversation

jazzdan
Copy link
Contributor

@jazzdan jazzdan commented Jun 11, 2020

No description provided.

@jazzdan jazzdan requested review from nicks and landism June 11, 2020 15:12
nicks
nicks approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@nicks nicks left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe leave a todo to add some sort of a grace_period param, like kubernetes does?

@jazzdan jazzdan merged commit c5f015c into master Jun 11, 2020
@nicks nicks deleted the dmiller/ch7581/increase-local-process-sigterm-timeout branch February 3, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicks nicks nicks approved these changes

@landism landism Awaiting requested review from landism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jazzdan @nicks