engine: fix up some display and calculations in the build graph #3498
+51
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: I noticed this issue independently of #3496. They might be related, but haven't been able to reproduce that. This PR is more about the opposite issue: erroneously skipping builds rather than erroneously repeating them |
landism
approved these changes
Jun 23, 2020
| } else { | ||
| // Otherwise, we can re-use results from the previous build. | ||
| if !q.isBuilding(id) { | ||
| // We can re-use results from the previous build. | ||
| // If needsOwnBuild is false, then LastSuccessfulResult must exist if it's empty. |
There was a problem hiding this comment.
not part of this PR so FFTI, but I found this comment really confusing!
- it mentions
needsOwnBuild, which is no longer what's checked. I think a refactor missed updating this comment. - what does "must exist if it's empty" mean? aren't "exists" and "empty" opposite states? or does "it's" here refer to something other than
LastSuccessfulResult?
There was a problem hiding this comment.
ya, i just removed this comment
nicks
commented
Jun 24, 2020
| } else { | ||
| // Otherwise, we can re-use results from the previous build. | ||
| if !q.isBuilding(id) { | ||
| // We can re-use results from the previous build. | ||
| // If needsOwnBuild is false, then LastSuccessfulResult must exist if it's empty. |
There was a problem hiding this comment.
ya, i just removed this comment
This improves the logs around when cached images are being reused, and why we're doing a rebuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/graph:
0366bb9 (2020-06-23 09:46:45 -0400)
engine: fix up some display and calculations in the build graph
This improves the logs around when cached images are being
reused, and why we're doing a rebuild.
It also fixes a bug where we were reusing a cached image
when we shouldn't have been.
Code review reminders, by giving a LGTM you attest that: