Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: turn restart_container deprecation warning into an error [ch7714] #3551

Merged
merged 1 commit into from Jul 6, 2020

Conversation

maiamcc
Copy link
Contributor

@maiamcc maiamcc commented Jul 2, 2020

Hello @landism, @nicks,

Please review the following commits I made in branch maiamcc/rm-update-container:

052b720 (2020-07-02 17:47:04 -0400)
tiltfile: turn restart_container deprecation warning into an error [ch7714]

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc maiamcc merged commit 3f7711b into master Jul 6, 2020
@maiamcc maiamcc deleted the maiamcc/rm-update-container branch July 6, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants