Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: clean up bookkeeping fields #3555

Merged
merged 1 commit into from Jul 7, 2020
Merged

k8s: clean up bookkeeping fields #3555

merged 1 commit into from Jul 7, 2020
+88 −6

Conversation

nicks
Copy link
Member

@nicks nicks commented Jul 6, 2020

Hello @jazzdan, @maiamcc,

Please review the following commits I made in branch nicks/managedfields:

72ced8a (2020-07-06 18:56:03 -0400)
k8s: clean up bookkeeping fields

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from jazzdan and maiamcc July 6, 2020 22:56
@nicks
Copy link
Member Author

nicks commented Jul 6, 2020

(this has annoyed me for a while, it makes everything much harder to debug)

jazzdan
jazzdan approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jazzdan jazzdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this worth a test?

@nicks
Copy link
Member Author

nicks commented Jul 7, 2020

added a test!

@nicks nicks merged commit d61e754 into master Jul 7, 2020
@nicks nicks deleted the nicks/managedfields branch July 7, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzdan jazzdan jazzdan approved these changes

@maiamcc maiamcc Awaiting requested review from maiamcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @jazzdan