analytics: tag tilt.up.running w/ subcommand #3560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
tilt.up.running
event also gets emitted bytilt ci
, and includes no information to distinguishtilt ci
fromtilt up
.Solution
Add a tag for the subcommand (e.g., "up", "ci") on
tilt.up.running
events.Notes
tilt.up.running
as well, but that makes this change riskier (since it gives us an inconsistency to account for in our analytics queries) and can be decoupled from this change.