Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: resources with extra pod selectors or images should be considered workloads #3561

Merged
merged 1 commit into from Jul 7, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Jul 7, 2020

Hello @jazzdan,

Please review the following commits I made in branch nicks/nonworkload:

993df2b (2020-07-07 12:30:59 -0400)
tiltfile: resources with extra pod selectors or images should be considered workloads

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from jazzdan July 7, 2020 16:31
@nicks
Copy link
Member Author

nicks commented Jul 7, 2020

I wonder if we should change the terminology here to "Podless" or something, since that what it means in practice (We don't track pods for nonworkloads)

@nicks nicks merged commit d4ba52b into master Jul 7, 2020
@nicks nicks deleted the nicks/nonworkload branch July 7, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants