Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: don't parallelize uncategorized yaml with other yaml. Fixes https://github.com/tilt-dev/tilt/issues/3421 #3567

Merged
merged 1 commit into from Jul 9, 2020
Merged

engine: don't parallelize uncategorized yaml with other yaml. Fixes https://github.com/tilt-dev/tilt/issues/3421 #3567

merged 1 commit into from Jul 9, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Jul 8, 2020

Hello @maiamcc, @landism,

Please review the following commits I made in branch nicks/ch8297:

0fd8038 (2020-07-08 15:58:22 -0400)
engine: don't parallelize uncategorized yaml with other yaml. Fixes #3421

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and maiamcc July 8, 2020 19:58
@nicks
Copy link
Member Author

nicks commented Jul 8, 2020

this has bitten me so many times at this point, it was easier just to fix it

@nicks nicks merged commit 67d142f into master Jul 9, 2020
@nicks nicks deleted the nicks/ch8297 branch July 9, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landism landism landism approved these changes

@maiamcc maiamcc Awaiting requested review from maiamcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

namespace applied out of order
2 participants
@nicks @landism