Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: fix a bug where resource_deps on non-workloads didn't work correctly #3574

Merged
merged 1 commit into from Jul 10, 2020
Merged

engine: fix a bug where resource_deps on non-workloads didn't work correctly #3574

merged 1 commit into from Jul 10, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Jul 9, 2020

Hello @jazzdan, @landism,

Please review the following commits I made in branch nicks/resource-deps:

872a060 (2020-07-09 19:21:48 -0400)
engine: fix a bug where resource_deps on non-workloads didn't work correctly

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from jazzdan and landism July 9, 2020 23:25
@nicks
Copy link
Member Author

nicks commented Jul 9, 2020

the data model here has gotten pretty messy. I'm trying to maintain some parity between LocalRuntimeState and K8sRuntimeState

landism
landism approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the data model here has gotten pretty messy.

yeah :(

a hunch that I haven't thought through too much is the "should this block deps" logic shouldn't belong to RuntimeState

@nicks
Copy link
Member Author

nicks commented Jul 10, 2020

ya, i think there's some fundamental error in how we're modelling this, but i haven't figured out what it is yet, but that's a good hypothesis.

@nicks
Copy link
Member Author

nicks commented Jul 10, 2020

also added an upper_test to better test how the pieces fit together

@nicks nicks merged commit e4e8b3f into master Jul 10, 2020
@nicks nicks deleted the nicks/resource-deps branch July 10, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landism landism landism approved these changes

@jazzdan jazzdan Awaiting requested review from jazzdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @landism