cli: add 'tilt dump image-deploy-ref', for determining the deploy tag of an image #3607
Conversation
internal/cli/dump.go
Outdated
| func newDumpImageDeployRefCmd() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "image-deploy-ref REF", | ||
| Short: "Determine the deployed name and tag of a custom-built image", |
There was a problem hiding this comment.
idk if this is actually clearer, take it or leave it 🤷
| Short: "Determine the deployed name and tag of a custom-built image", | |
| Short: "Determine the name and tag with which Tilt will deploy the given custom-built image", |
(and change in Long description as well)
| return nil, errors.Wrap(err, "DumpImageDeployRef") | ||
| } | ||
|
|
||
| data, _, err := d.dCli.ImageInspectWithRaw(ctx, ref) |
There was a problem hiding this comment.
Have a vague instinct that as much of this logic as possible should live in a helper function that's called by both dump-image... and the CustomBuilder, to guard against the logic going out of sync. How hard would that be?
There was a problem hiding this comment.
ya, that's how it works!
the helper function is digestAsTag.
everything else is type conversion, for types that are different in the two codepaths for good reasons.
|
Also are you going to update the Custom Build docs to reflect this strategy? |
nicks
force-pushed
the
nicks/ch8524
branch
2 times, most recently
from
db5e716
to
00eae28
Compare
|
yep, the attached issue outlines what the new docs will look like. it's a bit of an advanced feature (and i'm concerned that more people will use it incorrectly than use it correctly). But we're pairing with a partner team and watching closely how they use it |
… of an image helps with more complex custom_build commands as described in #3584
Hello @maiamcc, @landism,
Please review the following commits I made in branch nicks/ch8524:
d77706b (2020-07-22 16:58:12 -0400)
cli: add 'tilt dump image-deploy-ref', for determining the deploy tag of an image
helps with more complex custom_build commands as described in #3584
Code review reminders, by giving a LGTM you attest that: