Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check home path in linux before installing #3612

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Check home path in linux before installing #3612

merged 1 commit into from
Jul 23, 2020

Conversation

puerco
Copy link
Contributor

@puerco puerco commented Jul 23, 2020

Today I saw Brandon Philips report the same issue on twitter that I had when trying the install script.
He reported it in Ubuntu, I had the same issue on Fedora:

+ mv tilt /home/user/.local/bin/tilt
mv: cannot move 'tilt' to '/home/user/.local/bin/tilt': No such file or directory

The installer would assume that $HOME/.local/bin always exists Here is the fix.

nicks
nicks approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM!

@nicks nicks merged commit 4514dc3 into tilt-dev:master Jul 23, 2020
@puerco puerco deleted the fix-install-script branch July 23, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicks nicks nicks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puerco @nicks