logs: wire deps [ch8434] #3635
Merged
logs: wire deps [ch8434] #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzdan
approved these changes
Jul 29, 2020
nicks
approved these changes
Jul 29, 2020
internal/hud/server/logs_reader.go
Outdated
| @@ -94,17 +90,22 @@ func (ls *LogStreamer) Handle(v proto_webview.View) error { | |||
|
|
|||
| return nil | |||
| } | |||
| func StreamLogs(ctx context.Context, host model.WebHost, port model.WebPort, printer *hud.IncrementalPrinter) error { | |||
There was a problem hiding this comment.
model.WebURL might be a better choice here. it will behave correctly if the user specifies 0.0.0.0 (there's a subtle difference between the host we're listening on and the host we're connecting to)
There was a problem hiding this comment.
ugh it SHOULD be model.WebURL except that encodes the schema too :( i might play with it and split it out into model.BaseWebURL and model.WebURL
There was a problem hiding this comment.
oh wait duh I can just manipulate the url.URL to change the schema.
nicks
reviewed
Jul 29, 2020
internal/cli/logs.go
Outdated
| return err | ||
| } | ||
|
|
||
| return server.StreamLogs(ctx, logDeps.host, logDeps.port, logDeps.printer) |
There was a problem hiding this comment.
add the addConnectServerFlags() call to this file while you're here?
There was a problem hiding this comment.
I've got that in a different ticket!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nicks, @jazzdan,
Please review the following commits I made in branch maiamcc/logs-wire-deps:
ac4c504 (2020-07-29 15:10:08 -0400)
logs: wire deps [ch8434]
Code review reminders, by giving a LGTM you attest that: