New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleci: update docker #3637

Merged

nicks merged 1 commit into master from nicks/dockerupgrade

Jul 30, 2020

Member

nicks commented Jul 29, 2020

Hello @nicks,

Please review the following commits I made in branch nicks/dockerupgrade:

64dcf6d (2020-07-29 18:56:48 -0400)
circleci: update docker

Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

nicks force-pushed the nicks/dockerupgrade branch 2 times, most recently from aa3ff90 to ebbc056 Compare

July 30, 2020 03:40


          circleci: update docker

a6804d3

nicks force-pushed the nicks/dockerupgrade branch from ebbc056 to a6804d3 Compare

July 30, 2020 03:41

nicks merged commit 001e754 into master

nicks deleted the nicks/dockerupgrade branch

July 30, 2020 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment