Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: workaround a bug in kustomize #3641

Merged
merged 1 commit into from
Jul 30, 2020
Merged

tiltfile: workaround a bug in kustomize #3641

merged 1 commit into from
Jul 30, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Jul 30, 2020

Hello @jazzdan,

Please review the following commits I made in branch nicks/kustomize:

df55300 (2020-07-30 11:34:10 -0400)
tiltfile: workaround a bug in kustomize
for more details, see kubernetes-sigs/kustomize#2789

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from jazzdan July 30, 2020 15:34
@nicks
Copy link
Member Author

nicks commented Jul 30, 2020

wooooo our tests caught a real bug

@nicks nicks merged commit a55bbf4 into master Jul 30, 2020
@nicks nicks deleted the nicks/kustomize branch July 30, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants