tiltfile: add a force_parallel option for local_resource #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/ch8725
branch
2 times, most recently
from
6ebd8c1
to
c7d859c
Compare
landism
reviewed
Aug 13, 2020
| @@ -21,7 +21,7 @@ func NextTargetToBuild(state store.EngineState) *store.ManifestTarget { | |||
|
|
|||
| // Local targets aren't parallelizable with any other kind of target. | |||
| // So if we're already building a local target, bail immediately. | |||
| if IsBuildingLocalTarget(state) { | |||
| if IsBuildingUnparallelizableLocalTarget(state) { | |||
There was a problem hiding this comment.
unless I've misunderstood the intent of this PR, we also need to change the RemoveLocalTargets bit a few lines down
There was a problem hiding this comment.
oooh good catch! fixed and added a test
nicks
force-pushed
the
nicks/ch8725
branch
2 times, most recently
from
eb89e22
to
0804ecb
Compare
landism
approved these changes
Aug 13, 2020
Comment on lines
30
to
31
| // Some local targets aren't parallelizable with any other kind of target. | ||
| // So if we're already building any targets, remove all the local ones. |
There was a problem hiding this comment.
Suggested change
| // Some local targets aren't parallelizable with any other kind of target. | |
| // So if we're already building any targets, remove all the local ones. | |
| // Some local targets aren't parallelizable with any other kind of target. |
just since "all the local ones" is no longer accurate, a better wording doesn't come immediately to mind, and the function name does a pretty good job of communicating this anyway, might as well delete this second line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/ch8725:
12499b4 (2020-08-12 17:45:22 -0400)
tiltfile: add a force_parallel option for local_resource
Code review reminders, by giving a LGTM you attest that: