Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: record the helm dependency before running helm, to help iterate on helm charts #3729

Merged
merged 1 commit into from Aug 27, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Aug 26, 2020

Hello @landism,

Please review the following commits I made in branch nicks/helmwatch:

2abde4f (2020-08-26 17:53:58 -0400)
tiltfile: record the helm dependency before running helm, to help iterate on helm charts

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism August 26, 2020 21:54
@nicks nicks merged commit 32bc2b4 into master Aug 27, 2020
@nicks nicks deleted the nicks/helmwatch branch August 27, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants