Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add a --context flag for setting kube context #3734

Merged
merged 1 commit into from Aug 31, 2020
Merged

cli: add a --context flag for setting kube context #3734

merged 1 commit into from Aug 31, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Aug 28, 2020

Hello @maiamcc,

Please review the following commits I made in branch nicks/ch7777:

0627a11 (2020-08-28 19:03:41 -0400)
cli: add a --context flag for setting kube context

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from maiamcc August 28, 2020 23:03
@nicks nicks force-pushed the nicks/ch7777 branch 2 times, most recently from d1feeda to 7bfee69 Compare August 28, 2020 23:05
maiamcc
maiamcc approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nicks nicks merged commit 4501128 into master Aug 31, 2020
@nicks nicks deleted the nicks/ch7777 branch August 31, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiamcc maiamcc maiamcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @maiamcc