Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add an experimental API for enabling hosted opentelemetry/opencensus metrics #3736

Merged
merged 1 commit into from Aug 31, 2020
Merged

metrics: add an experimental API for enabling hosted opentelemetry/opencensus metrics #3736

merged 1 commit into from Aug 31, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Aug 31, 2020

Hello @landism,

Please review the following commits I made in branch nicks/ch9036:

2430b71 (2020-08-31 11:48:30 -0400)
metrics: add an experimental API for enabling hosted opentelemetry/opencensus metrics

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism August 31, 2020 15:48
@nicks
Copy link
Member Author

nicks commented Aug 31, 2020 •
edited

this might never be used by end users or documented...this is mainly so we can play around with it internally

@nicks nicks merged commit 3d1dee2 into master Aug 31, 2020
@nicks nicks deleted the nicks/ch9036 branch August 31, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landism landism landism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @landism