dockerignore: convert ignore patterns to absolute paths #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/ignore
branch
2 times, most recently
from
fc04157
to
192060d
Compare
nicks
commented
Sep 1, 2020
| @@ -421,9 +421,6 @@ func TestWatchNonexistentDirectory(t *testing.T) { | |||
| f := newNotifyFixture(t) | |||
| defer f.tearDown() | |||
|
|
|||
| ignore, _ := dockerignore.NewDockerPatternMatcher(f.paths[0], []string{"./"}) | |||
There was a problem hiding this comment.
i'm not totally sure what these were here for, but they're totally bogus -- they prevent the fsync() in this test from working
There was a problem hiding this comment.
oh haha - now i remember, i think they're working around a bug in windows where it gets change events for the directory...let me see what i can do about that...
There was a problem hiding this comment.
fixed! addressed it the same way i fixed it for macos
In most places in Tilt, we try to use absolute paths everywhere. So this makes things more consistent with the rest of Tilt, and lets us be a bit more flexible in how we handle subdirs and parent dirs in ignores. Fixes #3740
landism
approved these changes
Sep 2, 2020
|
YESSSSSSSSS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/ignore:
e19c045 (2020-09-01 18:07:57 -0400)
dockerignore: convert ignore patterns to absolute paths
In most places in Tilt, we try to use absolute paths everywhere.
So this makes things more consistent with the rest of Tilt, and lets us be
a bit more flexible in how we handle subdirs and parent dirs in ignores.
Fixes #3740
Code review reminders, by giving a LGTM you attest that: