model: better support for no-build no-push custom_builds #3747
Conversation
|
this is in response to the discussion here i understand this change is pretty weird. But I think it might be the kind of weird that cancels out existing weird, so that we're net less weird. |
nicks
force-pushed
the
nicks/no-push
branch
5 times, most recently
from
65a2ede
to
38ce9a0
Compare
internal/tiltfile/tiltfile_test.go
Outdated
| @@ -4029,6 +4029,24 @@ k8s_yaml('foo.yaml') | |||
| f.assertNextManifest("foo").ImageTargets[0].OverrideArgs) | |||
| } | |||
|
|
|||
| // See comments on ImageTarget#MaybeIgnoreRegistry() | |||
| func TestCustomBuildNoBuildNoPush(t *testing.T) { | |||
There was a problem hiding this comment.
not apparent what you're testing here b/c "no build no push" is a kinda wibbly translation of "skips local docker and doesn't use expected ref", and also since it's not immediately obvious what the behavior SHOULD be, I'd love it in the test name. How about:
TestCustomBuildSkipsLocalDockerAndTagPassedIgnoresLocalRegistry or something? Wordier but much easier to tell what's going on.
There was a problem hiding this comment.
done!
someday we'll come up with a custom_build v2!!!
Hello @maiamcc,
Please review the following commits I made in branch nicks/no-push:
881e7b7 (2020-09-02 17:50:04 -0400)
model: better support for no-build no-push custom_builds
Code review reminders, by giving a LGTM you attest that: