tiltfile: add map[string]string unpacker #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
approved these changes
Sep 3, 2020
internal/tiltfile/value/map.go
Outdated
| "go.starlark.net/starlark" | ||
| ) | ||
|
|
||
| type StringStringMap struct { |
There was a problem hiding this comment.
have you considered doing this as
type StringStringMap map[string]string
?
i think we only need the wrapper struct if we want to treat the "unset" value differently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to access the value via
.Mapis a little clumsy, but I'm not sure there's a way to avoid that.