builder implementation of outputs_image_ref_to for custom build scripts that want to compute their own tag #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is the build-engine side of #3760 |
nicks
force-pushed
the
nicks/custombuilder
branch
from
82d91d8
to
e89e3e1
Compare
landism
approved these changes
Sep 11, 2020
| _, err := f.cb.Build(f.ctx, refSetFromString("gcr.io/foo/bar"), cb) | ||
| require.NotNil(t, err) | ||
| assert.Contains(t, err.Error(), | ||
| fmt.Sprintf("Output image ref in file %s was invalid: could not parse ref docker.io/library/999", f.tdf.JoinPath("ref.txt"))) |
There was a problem hiding this comment.
nit: maybe ParseNamedTagged should return the original string in the error. If I got this error I'd think it pretty fishy that it's telling me it can't parse the value in my file but not showing me the actual value in the file. Probably worth %qing, too, to get a better error when the file is empty.
nicks
force-pushed
the
nicks/custombuilder
branch
from
e89e3e1
to
2c66054
Compare
…ts that want to compute their own tag
nicks
force-pushed
the
nicks/custombuilder
branch
from
2c66054
to
d79f673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/custombuilder:
82d91d8 (2020-09-11 15:28:27 -0400)
builder implementation of outputs_image_ref_to for custom build scripts that want to compute their own tag
Code review reminders, by giving a LGTM you attest that: