Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_build(outputs_image_ref_to=...) Tiltfile API #3769

Merged
merged 1 commit into from Sep 14, 2020
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Sep 11, 2020

Hello @landism,

Please review the following commits I made in branch nicks/ch9358:

2ee9c95 (2020-09-11 18:40:23 -0400)
Add custom_build(outputs_image_ref_to=...) Tiltfile API

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism September 11, 2020 22:41
@nicks nicks merged commit 292eba8 into master Sep 14, 2020
@nicks nicks deleted the nicks/ch9358 branch September 14, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants