Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround for https://github.com/moby/term/issues/15 #3804

Merged
merged 1 commit into from Sep 25, 2020
Merged

workaround for https://github.com/moby/term/issues/15 #3804

merged 1 commit into from Sep 25, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Sep 25, 2020

Hello @maiamcc,

Please review the following commits I made in branch nicks/term:

50ef19f (2020-09-25 17:40:45 -0400)
workaround for moby/term#15

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from maiamcc September 25, 2020 21:40
maiamcc
maiamcc approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 👍

@nicks nicks merged commit 804685d into master Sep 25, 2020
@nicks nicks deleted the nicks/term branch September 25, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiamcc maiamcc maiamcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @maiamcc