Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/resourceInfo: trim the URL we display for endpoints (and some renaming for consistency) [ch9652] #3835

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

maiamcc
Copy link
Contributor

@maiamcc maiamcc commented Oct 6, 2020

Hello @nicks, @hyu,

Please review the following commits I made in branch maiamcc/endpoints-in-web:

7989df6 (2020-10-06 17:04:31 -0400)
web/resourceInfo: trim the URL we display for endpoints (and some renaming for consistency) [ch9652]

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc maiamcc requested review from hyu and nicks October 6, 2020 21:04
Copy link
Member

@hyu hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 Nice!

@maiamcc maiamcc merged commit 52d80ff into master Oct 7, 2020
@maiamcc maiamcc deleted the maiamcc/endpoints-in-web branch October 7, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants