Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw our storybook ui components on https://storybook.tilt.dev/ #3840

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Oct 7, 2020

Hello @landism, @maiamcc,

Please review the following commits I made in branch nicks/storybook:

6083aeb (2020-10-07 19:22:55 -0400)
throw our storybook ui components on https://storybook.tilt.dev/

e48da37 (2020-10-07 13:01:06 -0400)
web: fix storybook server, add tests

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented Oct 7, 2020

this turned out to be a pretty easy POC so I can share in-progress UI work

most of the code is auto-generated from helm create, plus some copypasta from our other services

@landism
Copy link
Member

landism commented Oct 8, 2020

this turned out to be a pretty easy POC so I can share in-progress UI work

Just to make sure I understand, "in-progress UI work" here refers to stories that are in master but not yet used in the Tilt UI, and not stories that are in a branch and not yet in master?

@nicks
Copy link
Member Author

nicks commented Oct 8, 2020

"in master but not yet used in the Tilt UI" - this one, or "in master but not yet in a released version of Tilt, so you don't have to compile the latest version yourself to see it"

@nicks nicks merged commit 8b2a60a into master Oct 8, 2020
@nicks nicks deleted the nicks/storybook branch October 8, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants