Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: kubernetes uses klog/v2 now :shakes-fist: #3846

Merged
merged 1 commit into from
Oct 9, 2020
Merged

vendor: kubernetes uses klog/v2 now :shakes-fist: #3846

merged 1 commit into from
Oct 9, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Oct 9, 2020

Hello @landism,

Please review the following commits I made in branch nicks/klog2:

05c61f9 (2020-10-09 09:57:53 -0400)
vendor: kubernetes uses klog/v2 now :shakes-fist:

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism October 9, 2020 13:58
@nicks
Copy link
Member Author

nicks commented Oct 9, 2020

was wondering why --klog wasn't working for me anymore. silly go versioning rules

landism
landism approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ew

@nicks nicks merged commit 0100843 into master Oct 9, 2020
@nicks nicks deleted the nicks/klog2 branch October 9, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landism landism landism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @landism