Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: set the informer resync period to something more reasonable #3850

Merged
merged 1 commit into from
Oct 12, 2020
Merged

k8s: set the informer resync period to something more reasonable #3850

merged 1 commit into from
Oct 12, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Oct 12, 2020

Hello @maiamcc, @landism,

Please review the following commits I made in branch nicks/resync-period:

9fa8fdc (2020-10-12 15:43:42 -0400)
k8s: set the informer resync period to something more reasonable

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and maiamcc October 12, 2020 19:44
maiamcc
maiamcc approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. what does this address?

@nicks
Copy link
Member Author

nicks commented Oct 12, 2020

nothing in particular, just something i noticed and wondered about

@nicks
Copy link
Member Author

nicks commented Oct 12, 2020

(the linked groups thread has more background on what this is for)

@nicks nicks merged commit d1bca4b into master Oct 12, 2020
@nicks nicks deleted the nicks/resync-period branch October 12, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiamcc maiamcc maiamcc approved these changes

@landism landism Awaiting requested review from landism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @maiamcc