engine: add more artificial delays after local_resource 馃槩. Fixes https://github.com/tilt-dev/tilt/issues/3900 #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiamcc
approved these changes
Nov 5, 2020
| // Empirically, this sleep ensures that any local file changes are processed | ||
| // before the next build starts. | ||
| // | ||
| // At the moment (2020-01-31), local_resources will not build in parallel with |
There was a problem hiding this comment.
this is not always true with the introduction of allow_parallel, idk if it's worth at least mentioning that in the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @maiamcc,
Please review the following commits I made in branch nicks/ch10068:
245e779 (2020-11-02 17:20:19 -0500)
engine: add more artificial delays after local_resource 馃槩. Fixes #3900
Code review reminders, by giving a LGTM you attest that: