Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: add config.define_object. Fixes https://github.com/tilt-dev/tilt/issues/3334 #3912

Merged
merged 1 commit into from Nov 12, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 10, 2020

Hello @landism,

Please review the following commits I made in branch nicks/ch10114:

3b87a5e (2020-11-10 14:58:12 -0500)
tiltfile: add config.define_object. Fixes #3334

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism November 10, 2020 19:58
@nicks nicks merged commit 4c61929 into master Nov 12, 2020
@nicks nicks deleted the nicks/ch10114 branch November 12, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow arbitrary additional key/value pairs in tilt_config.json
2 participants