Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-based release process #3920

Merged
merged 1 commit into from Nov 12, 2020
Merged

ci-based release process #3920

merged 1 commit into from Nov 12, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 12, 2020

Hello @nicks,

Please review the following commits I made in branch nicks/release:

cb0773e (2020-11-12 15:50:50 -0500)
ci-based release process

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks force-pushed the nicks/release branch 5 times, most recently from 71dbf3b to a4b91c5 Compare November 12, 2020 21:29
@nicks
Copy link
Member Author

nicks commented Nov 12, 2020

OK! This is a revamp of the release process, based on the release process for ctlptl. Now you just create a tag v0.x.y and push it to git and circleci will run the release for you. GitOps!

@nicks
Copy link
Member Author

nicks commented Nov 12, 2020

going to merge this so i can do a release, happy to address comments on a follow-up PR!

@nicks nicks merged commit 02e4f8a into master Nov 12, 2020
@nicks nicks deleted the nicks/release branch November 12, 2020 23:21
Copy link
Contributor

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🥳

command: gcloud auth configure-docker
- run: ./scripts/release-ci.sh
- slack/status:
mentions: "nick"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still supposed to be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! also happy to mention others

Copy link
Member

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooo!!

Comment on lines +32 to +35
./scripts/upload-assets.py latest
goreleaser --rm-dist --skip-publish --snapshot

VERSION=$(git describe --abbrev=0 --tags)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, I think $CIRCLE_TAG instead of latest on 32 and $VERSION elsewhere would be a little more direct and leave less room for things to get weird (like, if a config error/change causes this job to run on a branch instead of a tag, the current code would use the latest tag rather than failing), but I don't think it's a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants