New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-based release process #3920
ci-based release process #3920
Conversation
71dbf3b
to
a4b91c5
Compare
OK! This is a revamp of the release process, based on the release process for ctlptl. Now you just create a tag v0.x.y and push it to git and circleci will run the release for you. GitOps! |
going to merge this so i can do a release, happy to address comments on a follow-up PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 🥳
command: gcloud auth configure-docker | ||
- run: ./scripts/release-ci.sh | ||
- slack/status: | ||
mentions: "nick" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep! also happy to mention others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woooo!!
./scripts/upload-assets.py latest | ||
goreleaser --rm-dist --skip-publish --snapshot | ||
|
||
VERSION=$(git describe --abbrev=0 --tags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, I think $CIRCLE_TAG
instead of latest
on 32 and $VERSION
elsewhere would be a little more direct and leave less room for things to get weird (like, if a config error/change causes this job to run on a branch instead of a tag, the current code would use the latest tag rather than failing), but I don't think it's a big deal
Hello @nicks,
Please review the following commits I made in branch nicks/release:
cb0773e (2020-11-12 15:50:50 -0500)
ci-based release process
Code review reminders, by giving a LGTM you attest that: