New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web ui/sidebar: another test, storybook entry #4140

Merged

maiamcc merged 1 commit into master from maiamcc/more-sidebar-tests

Jan 29, 2021

Contributor

maiamcc commented Jan 28, 2021

Hello @hyu, @landism,

Please review the following commits I made in branch maiamcc/more-sidebar-tests:

a970564 (2021-01-28 16:30:42 -0500)
web ui/sidebar: another test, storybook entry

Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics


          web ui/sidebar: another test, storybook entry

a970564

maiamcc requested review from hyu and landism

January 28, 2021 21:31

hyu approved these changes

View reviewed changes

Member

hyu left a comment

Nice! Thanks for making Storybook better... ☺️

maiamcc merged commit ad25720 into master

maiamcc deleted the maiamcc/more-sidebar-tests branch

January 29, 2021 18:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment