Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: tests for AlertsOnTop toggle [ch11068] #4180

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

maiamcc
Copy link
Contributor

@maiamcc maiamcc commented Feb 8, 2021

Hello @landism, @hyu,

Please review the following commits I made in branch maiamcc/alerts-on-top-tests:

a989a2b (2021-02-08 18:02:27 -0500)
ui: tests for AlertsOnTop toggle [ch11068]

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc maiamcc requested review from hyu and landism February 8, 2021 23:02
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #11068: "Alerts On Top" tests.

@maiamcc maiamcc changed the base branch from master to maiamcc/resource-toggle-onclick February 8, 2021 23:03
Base automatically changed from maiamcc/resource-toggle-onclick to master February 9, 2021 15:37
@maiamcc maiamcc merged commit e4d9f18 into master Feb 9, 2021
@maiamcc maiamcc deleted the maiamcc/alerts-on-top-tests branch February 9, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants